CIAB Bookings: Add eligibility check for Bookings tab #16139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
|
|
RafaelKayumov
approved these changes
Sep 17, 2025
Contributor
RafaelKayumov
left a comment
RafaelKayumov
left a comment
There was a problem hiding this comment.
LGTM. Just left a question.
| if let status, (products.filter { $0.statusKey == status.rawValue }.isEmpty) == false { | ||
| return onCompletion(.success(true)) | ||
| } else if status == nil { | ||
| } else if let productType, products.contains(where: { $0.productTypeKey == productType.rawValue}) { |
Contributor
There was a problem hiding this comment.
Question: Should we also update StorageType.loadProducts() and include product type into query instead of doing local filtering after a storage fetch.
Contributor
Author
There was a problem hiding this comment.
Good thinking! I optimized the code in bd9d56d, let me know what you think @RafaelKayumov.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of WOOMOB-1231
Description
This PR adds a new eligibility checker to determine if Bookings tab should be displayed for a store. The conditions include:
The checker will be used in a subsequent PR for showing Bookings tab.
Testing steps
Since the checker is not used yet, just unit tests passing should be sufficient.
Testing information
Added unit tests for
ProductStore,SessionManager, andBookingsTabEligibilityCheckerProtocol.Screenshots
N/A
RELEASE-NOTES.txtif necessary.